https://bugzilla.redhat.com/show_bug.cgi?id=1807224
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Flags| |fedora-review+
--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
xsecurelock.x86_64: E: description-line-too-long C XSecureLock is an X11 screen
lock utility designed with the primary goal of securi
ty.
→ please wrap.
xsecurelock.x86_64: W: no-version-in-last-changelog
→ please fix when importing.
+ package name is OK
+ latest version
+ license is acceptable for Fedora (ASL 2.0)
+ license is specified correctly
+ builds and installs OK
+ P/R/BR look OK
+ rpmlint finds some minor issues (listed above), fedora-review is happy
According to the Guidelines, BR using pkgconfig() virtual Provides are
preferred:
BuildRequires: libX11-devel → pkgconfig(x11)
BuildRequires: libXmu-devel → pkgconfig(xmu)
BuildRequires: libXrandr-devel → pkgconfig(xrandr)
BuildRequires: libXcomposite-devel → pkgconfig(xcomposite)
BuildRequires: libbsd-devel → pkgconfig(libbsd)
BuildRequires: fontconfig-devel → pkgconfig(fontconfig)
[see
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/#_buildrequires_pkgconfigfoo_vs_foo_devel].
I did NOT look at the functionality or security aspects of the package at all.
Sorry, I don't run X anymore and this would be too much work.
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
