https://bugzilla.redhat.com/show_bug.cgi?id=1813737
Artur Iwicki <fed...@svgames.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fed...@svgames.pl
Doc Type|--- |If docs needed, set a value
--- Comment #2 from Artur Iwicki <fed...@svgames.pl> ---
>License: GPL
The proper identifier here would be "GPLv3".
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
>Source0: ${url}/archive/v%{version}.tar.gz
percent-URL, not dollar-URL - the latter is a bash variable, not an rpm
variable.
>Requires: python-send2trash
Unversioned python is a big no-no in Fedora; use "python3-send2trash" here.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies
>install -p -D -m 0644 -t %{buildroot}/%{_datadir}/applications
>dist/%{name}.desktop
Add a BuildRequires for "desktop-file-utils" and run desktop-file-validate on
the installed desktop file.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
