https://bugzilla.redhat.com/show_bug.cgi?id=1813915



--- Comment #9 from Jaroslav Škarvada <jskar...@redhat.com> ---
Also one minor thing, you can define the global 'revision' macro at the
beginning of the spec file and calculate the shorthash by another macro, e.g.:

%global git_commit 7939e9652acb120d43d37db2eb0dea986f29785b
%global git_date 20200318

%global git_short_commit %(echo %{git_commit} | cut -c -8)
%global git_suffix %{git_date}git%{git_short_commit}

...
Release:          0.1.%{git_suffix}%{?dist}

I also noted there is spurious whitespace after the git HASH (before the new
line), please remove it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to