https://bugzilla.redhat.com/show_bug.cgi?id=1815154
--- Comment #3 from José Matos <jama...@fc.up.pt> ---
Thanks Fabian for taking the review.
(In reply to Fabian Affolter from comment #2)
> - The URL in Source0: could be replaced with %{pypi_source}
Done.
> - Please remove the formatting from %description
Sure.
> - For python3dist(sphinx) >= 2.0.0 the restriction can be removed as F31,
> F32 and Rawhide already are shipping more recent releases.
Actually I removed the manual provided Requires since they will be
autogenerated.
> - Fix the ownership in the %files section please.
What do you mean here? I searched the the generated rpm and I do not see any
problem in the ownership of the files. Apologies if this question looks dumb
but I am at loss here. :-)
> - License file is missing. Get in touch with upstream about the addition of
> it.
> - Some files are licensed under BSD
You are right.
There is already and issue open at the project
https://github.com/schettino72/sphinx_press_theme/issues/32
New spec file and srpm below:
Spec URL:
https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01312124-python-sphinx-press-theme/python-sphinx-press-theme.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01312124-python-sphinx-press-theme/python-sphinx-press-theme-0.5.1-2.fc33.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
