https://bugzilla.redhat.com/show_bug.cgi?id=1807365

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #4 from Robert-André Mauchin <[email protected]> ---
 - Use a better name for your archive:

Source0:       
https://github.com/%{name}/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz


 - Use the %cmake macro:

%cmake . -DBUILD_SHARED_LIBS=1 -DCMAKE_BUILD_TYPE=Debug \
        -DCMAKE_INSTALL_PREFIX=%{_prefix}

 - make %{?_smp_mflags} → %make_build

 - %ldconfig_scriptlets is not needed anymore

 - In order to avoid unintentional soname bump, we recommend not globbing the
major soname version, be more specific instead:

%{_libdir}/*.so.3*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to