https://bugzilla.redhat.com/show_bug.cgi?id=1812411

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com



--- Comment #3 from Robert-André Mauchin <zebo...@gmail.com> ---
 - Be more specific than that:

%{_bindir}/com.github.babluboy.bookworm
%{_datadir}/com.github.babluboy.bookworm
%{_datadir}/glib-2.0/schemas/com.github.babluboy.bookworm.gschema.xml
%{_datadir}/icons/hicolor/*/apps/com.github.babluboy.bookworm.svg
%{_datadir}/applications/com.github.babluboy.bookworm.desktop
%{_metainfodir}/com.github.babluboy.bookworm.appdata.xml

 - You need to handle the locales with %find_lang in %install

%find_lang com.github.babluboy.bookworm

[…]

%files -f com.github.babluboy.bookworm.lang

 - You need to Requires:      hicolor-icon-theme to own the icons directories

 - Validate the desktop file:

BuildRequires: desktop-file-utils

[…]

desktop-file-validate
%{buildroot}/%{_datadir}/applications/com.github.babluboy.bookworm.desktop

 - Validate the Appdata:

BuildRequires: libappstream-glib

[…]

appstream-util validate-relax --nonet
%{buildroot}%{_metainfodir}/com.github.babluboy.bookworm.appdata.xml

Validation will fail:

+ appstream-util validate-relax --nonet
/builddir/build/BUILDROOT/bookworm-1.1.2-2.fc33.x86_64/usr/share/metainfo/com.github.babluboy.bookworm.appdata.xml
/builddir/build/BUILDROOT/bookworm-1.1.2-2.fc33.x86_64/usr/share/metainfo/com.github.babluboy.bookworm.appdata.xml:
FAILED:
? tag-invalid           : <release> version was duplicated
? tag-invalid           : <release> versions are not in order [1.0.0 before
1.1.0]
Validation of files failed

See with upstream how to fix this.


 - Remove .wef:

Release:  2%{?dist}.wef

 - Separate your %changelog entries by a new line

 - don't include Fedora release in changelog entry:

* Wed Mar 11 2020 Bob Hepple <bob.hep...@gmail.com> - 1.1.2-2
- fix Source0

* Sat Feb 22 2020 Bob Hepple <bob.hep...@gmail.com> - 1.1.2-1
- Initial version of the package

 - Use a better name for your archive:

Source0:  %{url}/archive/%{version}/%{name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to