Robert-André Mauchin <> changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #3 from Robert-André Mauchin <> ---
 - Be more specific than that:


 - You need to handle the locales with %find_lang in %install

%find_lang com.github.babluboy.bookworm


%files -f com.github.babluboy.bookworm.lang

 - You need to Requires:      hicolor-icon-theme to own the icons directories

 - Validate the desktop file:

BuildRequires: desktop-file-utils



 - Validate the Appdata:

BuildRequires: libappstream-glib


appstream-util validate-relax --nonet

Validation will fail:

+ appstream-util validate-relax --nonet
? tag-invalid           : <release> version was duplicated
? tag-invalid           : <release> versions are not in order [1.0.0 before
Validation of files failed

See with upstream how to fix this.

 - Remove .wef:

Release:  2%{?dist}.wef

 - Separate your %changelog entries by a new line

 - don't include Fedora release in changelog entry:

* Wed Mar 11 2020 Bob Hepple <> - 1.1.2-2
- fix Source0

* Sat Feb 22 2020 Bob Hepple <> - 1.1.2-1
- Initial version of the package

 - Use a better name for your archive:

Source0:  %{url}/archive/%{version}/%{name}-%{version}.tar.gz

You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
package-review mailing list --
To unsubscribe send an email to
Fedora Code of Conduct:
List Guidelines:
List Archives:

Reply via email to