https://bugzilla.redhat.com/show_bug.cgi?id=1817267

Artur Iwicki <fed...@svgames.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fed...@svgames.pl
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Artur Iwicki <fed...@svgames.pl> ---
>Source0: https://github.com/google/libphonenumber/archive/v%{version}.tar.gz
With GitHub, you can use
"https://github.com/google/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz";.

>CFLAGS="${CFLAGS:-%optflags}"
>CXXFLAGS="${CXXFLAGS:-%optflags}"
>export CFLAGS CXXFLAGS
>(
> cd cpp/build
> %{__cmake} -DCMAKE_INSTALL_PREFIX:PATH=%{_prefix} ..
>)
I'm quite sure that calling cmake using the %cmake macro will take care of
properly setting CFLAGS/CXXFLAGS.
Alternatively, you can call the %set_build_flags macro to make sure the env
vars are set properly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to