https://bugzilla.redhat.com/show_bug.cgi?id=1814682
--- Comment #32 from l...@mellanox.com ---
(In reply to Michal Schmidt from comment #31)
> Thank you Honggang for the detailed review results.
> I disagree with the overall PASSED result, though the package is almost
> there.
>
>
> Liming,
>
> please fix this item flagged by fedora-review:
> > [!]: Uses parallel make %{?_smp_mflags} macro.
> The recommended fix is to use the "%make_build" macro.
>
> You still have this in the %install section:
> > %__spec_install_post
> Please remove it.
>
> About these BRs:
> > BuildRequires: systemd-units
> > BuildRequires: systemd-rpm-macros
> The first one seems unnecessary.
> systemd-rpm-macros should be sufficient.
Thanks Michal! I'll use %make_build and remove the %__spec_install_post in next
post.
As for the "systemd-units", it appears to be required by koji. I got some
failures like below once removed it. So I'll leave it for now (please correct
me if I am incorrect).
https://koji.fedoraproject.org/koji/taskinfo?taskID=43163313
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
