https://bugzilla.redhat.com/show_bug.cgi?id=1773720
Ryan O'Hara <roh...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(bperkins@redhat.c
| |om)
--- Comment #9 from Ryan O'Hara <roh...@redhat.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
- ASL 2.0
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 4 files have
unknown license. Detailed output of licensecheck in
/home/rohara/1773720-golang-github-haproxytech-
dataplaneapi/licensecheck.txt
- The source contains LICENSE file containig Apache License 2.0.
[ ]: License file installed when any subpackage combination is installed.
- The license is definitely installed with the regular rpm and/or the -devel
package. Does this requirement also apply to debuginfo and debugsource
packages? I'm going to assume not.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/logrotate.d
- I don't think this is optional. Having the "suggests" line is the spec seems
ok, but this package is creating a directory with no owner.
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
- This seems like an issue with all Go modules, as mentioned above.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
- All good.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
- All good.
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in golang-github-haproxytech-
dataplaneapi
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-haproxytech-dataplaneapi-devel
- Can we do this? I know upstream is versioning the releases of the various
dataplaneapi components. I'm not sure if this works for go packages.
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
- No issues above. Latest version is packaged and there is no upstream gpg key
to use for verify.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
- All good.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: golang-github-haproxytech-dataplaneapi-1.2.4-6.fc33.x86_64.rpm
golang-github-haproxytech-dataplaneapi-devel-1.2.4-6.fc33.noarch.rpm
golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-6.fc33.x86_64.rpm
golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-6.fc33.x86_64.rpm
golang-github-haproxytech-dataplaneapi-1.2.4-6.fc33.src.rpm
golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath
golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E:
description-line-too-long C This package provides debug sources for package
golang-github-haproxytech-dataplaneapi.
5 packages and 0 specfiles checked; 1 errors, 1 warnings.
Rpmlint (debuginfo)
-------------------
Checking:
golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-6.fc33.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
golang-github-haproxytech-dataplaneapi.x86_64: W: invalid-url URL:
https://github.com/haproxytech/dataplaneapi <urlopen error [Errno -2] Name or
service not known>
golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E:
description-line-too-long C This package provides debug sources for package
golang-github-haproxytech-dataplaneapi.
golang-github-haproxytech-dataplaneapi-debugsource.x86_64: W: invalid-url URL:
https://github.com/haproxytech/dataplaneapi <urlopen error [Errno -2] Name or
service not known>
golang-github-haproxytech-dataplaneapi-debuginfo.x86_64: W: invalid-url URL:
https://github.com/haproxytech/dataplaneapi <urlopen error [Errno -2] Name or
service not known>
golang-github-haproxytech-dataplaneapi-devel.noarch: W: invalid-url URL:
https://github.com/haproxytech/dataplaneapi <urlopen error [Errno -2] Name or
service not known>
golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath
4 packages and 0 specfiles checked; 1 errors, 5 warnings.
- I'd love to fix the URL issue since we've seen that in every package we've
reviewed for the dataplaneapi effort. Probably more important is the error
regarding the description line is too long.
# rpm -qip
golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-6.fc33.x86_64.rpm
Name : golang-github-haproxytech-dataplaneapi-debugsource
Version : 1.2.4
Release : 6.fc33
Architecture: x86_64
Install Date: (not installed)
Group : Development/Debug
Size : 2785503
License : ASL 2.0
Signature : (none)
Source RPM : golang-github-haproxytech-dataplaneapi-1.2.4-6.fc33.src.rpm
Build Date : Mon 13 Apr 2020 01:20:34 PM CDT
Build Host : wilco
URL : https://github.com/haproxytech/dataplaneapi
Summary : Debug sources for package golang-github-haproxytech-dataplaneapi
Description :
This package provides debug sources for package
golang-github-haproxytech-dataplaneapi.
Debug sources are useful when developing applications that use this
package or when debugging this package.
- So that looks too long:
# echo "This package provides debug sources for package
golang-github-haproxytech-dataplaneapi." | wc -c
88
- Can we shorten this? rpmlint sees this as an error.
Source checksums
----------------
https://github.com/haproxytech/dataplaneapi/archive/v1.2.4/dataplaneapi-1.2.4.tar.gz
:
CHECKSUM(SHA256) this package :
e1791a5475485cb7520d5102509614d072781fc576481eca128e96607c43e12c
CHECKSUM(SHA256) upstream package :
e1791a5475485cb7520d5102509614d072781fc576481eca128e96607c43e12c
Requires
--------
golang-github-haproxytech-dataplaneapi (rpmlib, GLIBC filtered):
/bin/sh
config(golang-github-haproxytech-dataplaneapi)
haproxy
libc.so.6()(64bit)
libpthread.so.0()(64bit)
rtld(GNU_HASH)
systemd
golang-github-haproxytech-dataplaneapi-devel (rpmlib, GLIBC filtered):
go-filesystem
golang(github.com/GehirnInc/crypt)
golang(github.com/GehirnInc/crypt/md5_crypt)
golang(github.com/GehirnInc/crypt/sha256_crypt)
golang(github.com/GehirnInc/crypt/sha512_crypt)
golang(github.com/docker/go-units)
golang(github.com/go-openapi/errors)
golang(github.com/go-openapi/loads)
golang(github.com/go-openapi/runtime)
golang(github.com/go-openapi/runtime/flagext)
golang(github.com/go-openapi/runtime/middleware)
golang(github.com/go-openapi/runtime/security)
golang(github.com/go-openapi/spec)
golang(github.com/go-openapi/strfmt)
golang(github.com/go-openapi/swag)
golang(github.com/go-openapi/validate)
golang(github.com/haproxytech/client-native)
golang(github.com/haproxytech/client-native/configuration)
golang(github.com/haproxytech/client-native/runtime)
golang(github.com/haproxytech/config-parser)
golang(github.com/haproxytech/config-parser/types)
golang(github.com/haproxytech/models)
golang(github.com/jessevdk/go-flags)
golang(github.com/rs/cors)
golang(github.com/shirou/gopsutil/host)
golang(github.com/shirou/gopsutil/mem)
golang(github.com/sirupsen/logrus)
golang(golang.org/x/net/netutil)
golang(golang.org/x/sys/unix)
golang-github-haproxytech-dataplaneapi-debuginfo (rpmlib, GLIBC filtered):
golang-github-haproxytech-dataplaneapi-debugsource (rpmlib, GLIBC filtered):
Provides
--------
golang-github-haproxytech-dataplaneapi:
config(golang-github-haproxytech-dataplaneapi)
golang-github-haproxytech-dataplaneapi
golang-github-haproxytech-dataplaneapi(x86-64)
golang-github-haproxytech-dataplaneapi-devel:
golang(github.com/haproxytech/dataplaneapi)
golang(github.com/haproxytech/dataplaneapi/adapters)
golang(github.com/haproxytech/dataplaneapi/handlers)
golang(github.com/haproxytech/dataplaneapi/haproxy)
golang(github.com/haproxytech/dataplaneapi/misc)
golang(github.com/haproxytech/dataplaneapi/operations)
golang(github.com/haproxytech/dataplaneapi/operations/acl)
golang(github.com/haproxytech/dataplaneapi/operations/backend)
golang(github.com/haproxytech/dataplaneapi/operations/backend_switching_rule)
golang(github.com/haproxytech/dataplaneapi/operations/bind)
golang(github.com/haproxytech/dataplaneapi/operations/configuration)
golang(github.com/haproxytech/dataplaneapi/operations/defaults)
golang(github.com/haproxytech/dataplaneapi/operations/discovery)
golang(github.com/haproxytech/dataplaneapi/operations/filter)
golang(github.com/haproxytech/dataplaneapi/operations/frontend)
golang(github.com/haproxytech/dataplaneapi/operations/global)
golang(github.com/haproxytech/dataplaneapi/operations/http_request_rule)
golang(github.com/haproxytech/dataplaneapi/operations/http_response_rule)
golang(github.com/haproxytech/dataplaneapi/operations/information)
golang(github.com/haproxytech/dataplaneapi/operations/log_target)
golang(github.com/haproxytech/dataplaneapi/operations/reloads)
golang(github.com/haproxytech/dataplaneapi/operations/server)
golang(github.com/haproxytech/dataplaneapi/operations/server_switching_rule)
golang(github.com/haproxytech/dataplaneapi/operations/sites)
golang(github.com/haproxytech/dataplaneapi/operations/specification)
golang(github.com/haproxytech/dataplaneapi/operations/stats)
golang(github.com/haproxytech/dataplaneapi/operations/stick_rule)
golang(github.com/haproxytech/dataplaneapi/operations/tcp_request_rule)
golang(github.com/haproxytech/dataplaneapi/operations/tcp_response_rule)
golang(github.com/haproxytech/dataplaneapi/operations/transactions)
golang-github-haproxytech-dataplaneapi-devel
golang-ipath(github.com/haproxytech/dataplaneapi)
golang-github-haproxytech-dataplaneapi-debuginfo:
debuginfo(build-id)
golang-github-haproxytech-dataplaneapi-debuginfo
golang-github-haproxytech-dataplaneapi-debuginfo(x86-64)
golang-github-haproxytech-dataplaneapi-debugsource:
golang-github-haproxytech-dataplaneapi-debugsource
golang-github-haproxytech-dataplaneapi-debugsource(x86-64)
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -L /home/rohara/tmp/rpms/ -b 1773720
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Perl, Python, C/C++, fonts, Ocaml, PHP, Java, SugarActivity,
R, Haskell
Built with local dependencies:
/home/rohara/tmp/rpms/golang-github-haproxytech-config-parser-devel-1.2.0-1.fc33.noarch.rpm
/home/rohara/tmp/rpms/golang-github-haproxytech-client-native-devel-1.2.6-2.fc33.noarch.rpm
/home/rohara/tmp/rpms/golang-github-haproxytech-models-devel-1.2.4-2.fc33.noarch.rpm
/home/rohara/tmp/rpms/golang-github-gehirninc-crypt-devel-0-0.2.20191113git6c0105a.fc33.noarch.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
