https://bugzilla.redhat.com/show_bug.cgi?id=1828813



--- Comment #9 from Alessio <[email protected]> ---
(In reply to Artem from comment #8)

> rpmlint says that packages requires only '/usr/bin/bash' so probably safe to
> add there this packages explicitly. Also zram for example package:
> https://src.fedoraproject.org/rpms/zram/blob/master/f/zram.spec#_18

Like there I also added 

%build
# None required

> Also, please, replace awk with gawk as i mentioned there
> https://bugzilla.redhat.com/show_bug.cgi?id=1828813#c5

Whoops, you are right

> Here is why this recommended to do:
> https://bugzilla.redhat.com/show_bug.cgi?id=1694366#c14

Thanks.

> This is cosmetic, but usually maintainers doing like this:
> 
> %doc README.md
> %doc CHANGELOG.md
> ->
> %doc README.md CHANGELOG.md

Done.

> Please fix this minor issues before import. Package approved.

Thank you very much.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to