https://bugzilla.redhat.com/show_bug.cgi?id=1830086
Artur Iwicki <fed...@svgames.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fed...@svgames.pl
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Artur Iwicki <fed...@svgames.pl> ---
>Spec URL: https://github.com/getpatchwork/git-pw/blob/master/rpm/git-pw.spec
This link leads to a syntax-highlighted HTML rendition of the file. Please use
the "raw file" links.
>%global name git-pw
>%define version 1.9.0
Uhh, why? If you write "Name: git-pw" it will automatically define a %{name}
macro. The same for the Version: tag and %{version} macro.
>Requires: python3-arrow
>Requires: python3-click
>Requires: python3-requests
>Requires: python3-setuptools
>Requires: python3-six
>Requires: python3-tabulate
I think those are not needed, since they will be emitted by the automatic
Python dependency generator.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies
>%description
>git-pw is a tool for integrating Git with Patchwork, the web-based patch \
>tracking system.
Putting a backslash at the end of the line escapes the newline and merges those
two lines into a single, 89-chars long line. There should be no lines in
%description that are longer than 80 characters.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description
>%{_mandir}/man1/git-pw*.1.gz
Do not assume that man pages will be gzipped. You should use a wildcard that
can match any compression method (including no compression at all).
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
