https://bugzilla.redhat.com/show_bug.cgi?id=1833472



--- Comment #2 from Jerry James <[email protected]> ---
(In reply to dan.cermak from comment #1)
> I think the name is good as it is and way better than
> ocaml-ocaml-compiler-libs.
> 
> Two minor issues:
> - Where did you obtain the minimum required version of dune from? Upstream's
> opam file has a 1.0 and not 1.5.1.

Whoops, I was looking at git head instead of the 0.12.1 release.  Fixed.

> - Contributing.md is imho not useful in a system package.

Agreed.  I have removed it.  Changes at the URLs above.

> Beside that: package approved!

Thank you, Dan!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to