https://bugzilla.redhat.com/show_bug.cgi?id=1836540
Erich Eickmeyer <er...@ericheickmeyer.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(fed...@svgames.pl
| |)
--- Comment #2 from Erich Eickmeyer <er...@ericheickmeyer.com> ---
>You should use the %cmake macro instead of a "raw" cmake call here, it'll
>ensure that CFLAGS/CXXFLAGS/LDFLAGS are set up properly
Fixed.
>>%install
>>rm -rf $RPM_BUILD_ROOT
>Don't do this.
>https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
There is nothing in that link that says that `rm -rf $RPM_BUILD_ROOT` should
not be used. It says `BuildRoot:` should not be used, but that's not what is
being done there. Besides, that was part of the default rpm spec template, so
does that mean there's a bug in the template?
I'll have new SRPM/SPEC files as soon as COPR starts working again.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
