Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=650452

Adam Williamson <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
         AssignedTo|[email protected]    |[email protected]
               Flag|                            |fedora-review+

--- Comment #1 from Adam Williamson <[email protected]> 2010-11-29 14:40:04 
EST ---
rpmlint meego-cursor-theme-0.4-1.20101107git74495cbe.fc15.src.rpm 
meego-cursor-theme.src:3: W: macro-in-comment %{name}
meego-cursor-theme.src:3: W: macro-in-comment %{version}
meego-cursor-theme.src:3: W: macro-in-comment %{git_version}
meego-cursor-theme.src:3: W: macro-in-comment %{name}
meego-cursor-theme.src:3: W: macro-in-comment %{version}
meego-cursor-theme.src:3: W: macro-in-comment %{gitdate}
meego-cursor-theme.src: W: no-buildroot-tag
meego-cursor-theme.src: W: invalid-url Source0:
meego-cursor-theme-0.4-20101107.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 8 warnings.

rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/meego-cursor-theme-0.4-1.20101107git74495cbe.fc15.noarch.rpm
meego-cursor-theme.noarch: W: incoherent-version-in-changelog 0.4-1
['0.4-1.20101107git74495cbe.fc15', '0.4-1.20101107git74495cbe']
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

macro-in-comment and invalid-url are OK as they are due to this being a
snapshot build and the comment correctly documents the creation of the
snapshot. versioning is in line with policy -
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Version .
incoherent-version-in-changelog is okay as I understand it, you just chose to
leave the snapshot info out of the changelog versioning.

all MUST and SHOULD items are okay and the package builds, review approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to