Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=654476 Adam Williamson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review?, needinfo-, | |needinfo?(pbrobin...@gmail. | |com) --- Comment #1 from Adam Williamson <[email protected]> 2010-11-29 19:21:37 EST --- [ad...@adam SRPMS]$ rpmlint meego-facebook-plugins-1.1.1-1.fc15.src.rpm meego-facebook-plugins.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging meego-facebook-plugins.src: W: spelling-error Summary(en_US) libsocialweb -> subsocial, dissociable, socialization meego-facebook-plugins.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging meego-facebook-plugins.src: W: spelling-error %description -l en_US libsocialweb -> subsocial, dissociable, socialization meego-facebook-plugins.src:3: W: macro-in-comment %{name} meego-facebook-plugins.src:3: W: macro-in-comment %{version} meego-facebook-plugins.src:3: W: macro-in-comment %{version} meego-facebook-plugins.src:3: W: macro-in-comment %{name} meego-facebook-plugins.src:3: W: macro-in-comment %{version} meego-facebook-plugins.src:3: W: macro-in-comment %{gitdate} meego-facebook-plugins.src: W: no-buildroot-tag meego-facebook-plugins.src: W: invalid-url Source0: meego-facebook-plugins-1.1.1.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 12 warnings. [ad...@adam SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/meego-facebook-plugins-1.1.1-1.fc15.x86_64.rpm /var/lib/mock/fedora-rawhide-x86_64/result/meego-facebook-plugins-bisho-1.1.1-1.fc15.x86_64.rpm meego-facebook-plugins.x86_64: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging meego-facebook-plugins.x86_64: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging meego-facebook-plugins-bisho.x86_64: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging meego-facebook-plugins-bisho.x86_64: W: spelling-error %description -l en_US libsocialweb -> subsocial, dissociable, socialization meego-facebook-plugins-bisho.x86_64: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging 2 packages and 0 specfiles checked; 0 errors, 5 warnings. spelling errors - feh. macro-in-comment and invalid-url are due to snapshot tarball, which is handled correctly. "MUST: The License field in the package spec file must match the actual license. [3]" the license on the libsocialweb stuff is LGPLv2, not LGPLv2+ : "This program is free software; you can redistribute it and/or modify it under the terms and conditions of the GNU Lesser General Public License, version 2.1, as published by the Free Software Foundation." the stuff in tools/ and some of the stuff in auth-observer is licensed as LGPLv2+. I'm not sure if any of those bits are 'independent' from the stuff in libsocialweb. AIUI, if it all builds together into one thing you have to use as a lump, we should just consider the whole thing as being LGPLv2. If you can use any of the LGPLv2+ licensed bits independently of the LGPLv2 licensed bits, we should call it 'LGPLv2 and LGPLv2+'. MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] The spec lists: %{_libdir}/mission-control-plugins.0/mcp-account-manager-socialweb.so I'm not sure about that %{_libdir}/mission-control-plugins.0 directory. As far as I can tell, telepathy-mission-control doesn't provide it. Can you check this? I think that's all. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
