https://bugzilla.redhat.com/show_bug.cgi?id=1839470



--- Comment #2 from Mohamed El Morabity <[email protected]> ---
Thanks for your review :)

> The upstream URL should point to
> https://github.com/googleapis/api-common-protos instead of PyPI from mym
> point of view.
And you're right, seems better.

> Could you please remove any possible available eggs in %prep, e.g., rm -rf
> %{pypi_name}.egg-info?
Good catch

All of these issues will be fixed at import.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to