https://bugzilla.redhat.com/show_bug.cgi?id=1840224
--- Comment #2 from Stefano Figura <stef...@figura.im> ---
(In reply to Michel Alexandre Salim from comment #1)
> Could you file an issue against upstream for the broken symlink for
> README.md too, and add the link to the spec? I suspect it used to share a
> git repo with another project and someone forgot to update the README after
> the split.
>
> Also -- `rm -vr expat` is commented out so you're not stripping out the
> bundled expat. If I uncomment it, build fails:
>
> ```
> --- stdout
> running: "cmake" "/builddir/build/BUILD/expat-sys-2.1.6/expat"
> "-DBUILD_shared=OFF" "-DBUILD_tools=OFF" "-DBUILD_examples=OFF"
> "-DBUILD_tests=OFF"
> "-DCMAKE_INSTALL_PREFIX=/builddir/build/BUILD/expat-sys-2.1.6/target/release/
> build/expat-sys-23aa5946dcba096c/out" "-DCMAKE_C_FLAGS= -ffunction-sections
> -fdata-sections -fPIC -m64" "-DCMAKE_C_COMPILER=/usr/bin/cc"
> "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64"
> "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections
> -fdata-sections -fPIC -m64" "-DCMAKE_ASM_COMPILER=/usr/bin/cc"
> "-DCMAKE_BUILD_TYPE=Release"
>
> --- stderr
> CMake Error: The source directory
> "/builddir/build/BUILD/expat-sys-2.1.6/expat" does not exist.
> Specify --help for usage, or press the help button on the CMake GUI.
> thread 'main' panicked at '
> command did not execute successfully, got: exit code: 1
>
> ```
>
> I encountered this too with bzip2-sys; even if upstream supports looking up
> the system library via pkgconfig, it will not find it if you don't add this
> as a BuildRequires.
>
> Add this below the existing BuildRequires on rust-packaging:
>
> BuildRequires: pkgconfig(expat)
>
>
> This should allow the build to succeed against the system expat instead of
> the bundled one.
Thanks for the review! Will fix the README.md issue.
One confusing thing about `rm -vr expat`. I see that both spec on sr.ht and on
my machine do not even it commented out. Am I missing something?
```
%prep
%autosetup -n %{crate}-%{version_no_tilde} -p1
rm -vr expat
%cargo_prep
```
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
