https://bugzilla.redhat.com/show_bug.cgi?id=1844120



--- Comment #1 from Vasiliy Glazov <[email protected]> ---
1. Remove Group tag.
  
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

2. Change
%setup -qn jamulus-%{commit0}
to
%autosetup -n jamulus-%{commit0}

3. Don't use macro for "install" command
   https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros

4. Correct desktop file install
  
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage

5. Remove %post, %postun and %posttrans sections. Scriptlets for desktop file
and mime not needed now.


After that I will see at build flags and why you change them.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to