https://bugzilla.redhat.com/show_bug.cgi?id=1845322



--- Comment #4 from Eugene A. Pivnev <[email protected]> ---
(In reply to Robert-André Mauchin from comment #3)

> Asking upstream is sufficient, you shouldn't join your own License copy.

Fixed.
URL to vendor's license reference added.

>  - Group is not used in Fedora

Fixed.

>  - Globbing the entire %{python3_sitearch} is forbidden, please be more
> specific instead:
> 
> %{python3_sitearch}/Kyoto_Cabinet-1.5-py*.egg-info
> %{python3_sitearch}/kyotocabinet*.so

Fixed, thank you.

>  - License:   GLPv3 → License:        GPLv3

Fixed.

>  - Install example/ as %doc?

Added.

>  - %define    module  kyotocabinet → %global  module  kyotocabinet

Fixed.

====
SPEC:
https://tieugene.fedorapeople.org/rpms/python-kyotocabinet/python-kyotocabinet.spec
SRPM:
https://tieugene.fedorapeople.org/rpms/python-kyotocabinet/python-kyotocabinet-1.22-2.fc32.src.rpm
Koji builds:
- f33: https://koji.fedoraproject.org/koji/taskinfo?taskID=46285578
- f32: https://koji.fedoraproject.org/koji/taskinfo?taskID=46285740
- f31: https://koji.fedoraproject.org/koji/taskinfo?taskID=46285947


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to