https://bugzilla.redhat.com/show_bug.cgi?id=1851617

Lyes Saadi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Lyes Saadi <[email protected]> ---
Hello :)!

> make %{?_smp_mflags}

Why not using %make_build? Adding to that, there is this Change which might get
accepted: https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro...

> %{_libdir}/lib*.so.*

You are upstream apparently, but this is still a bad idea to use a "*" for .so
versioning. You might forget that it increased or someone might take ownership
of the package in the future and not notice it.

> %{_includedir}/gamerzilla/*

Unowned directory =>
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/#_wildcarding_files_inside_a_created_directory


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to