https://bugzilla.redhat.com/show_bug.cgi?id=1851586

Robert-AndrĂ© Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Robert-AndrĂ© Mauchin <[email protected]> ---
Something is wrong here: you do not link to upstream but to your own repo, you
just unzip an archive coming from somewhere not mentioned, you don't install
from Source but from unzipping binaries directly into buildroot.

You should point to upstream Github and follow their install instruction with
meson. 
Also respect the format for the changelog entry.
Your package is missing a description entry.
Don't mix tabs and spaces.
Please get to know the guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/

Name:           pulseaudio-equalizer-ladspa
Version:        3.0.2
Release:        1%{?dist}
Summary:        A 15-band equalizer for PulseAudio

License:        GPLv3+
URL:            https://github.com/pulseaudio-equalizer-ladspa/equalizer
Source0:        %url/archive/v%{version}/%{name}-%{version}.tar.gz
BuildArch:      noarch

BuildRequires:  desktop-file-utils
BuildRequires:  python3-devel
BuildRequires:  glib2-devel
BuildRequires:  meson
Requires:       pulseaudio-utils
Requires:       gtk3
Requires:       python3-gobject
Requires:       ladspa-swh-plugins
Requires:       bc

%description
A LADSPA based multiband equalizer approach for getting better sound out of
pulseaudio.

%prep
%autosetup -n equalizer-%{version}

%build
%meson
%meson_build

%install
%meson_install

desktop-file-validate
%{buildroot}%{_datadir}/applications/com.github.pulseaudio-equalizer-ladspa.Equalizer.desktop

%files
%license LICENSE
%doc README.md
%{_bindir}/pulseaudio-equalizer
%{_bindir}/pulseaudio-equalizer-gtk
%{_datadir}/%{name}/
%{_datadir}/applications/com.github.pulseaudio-equalizer-ladspa.Equalizer.desktop
%{python3_sitearch}/pulseeq/

%changelog
* Tue Jun 30 11:43:43 CEST 2020 Sean Mottles <[email protected]> - 3.0.2-1
- Initial package


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to