https://bugzilla.redhat.com/show_bug.cgi?id=1851405



--- Comment #6 from Robert-André Mauchin 🐧 <zebo...@gmail.com> ---
(In reply to Кощеев from comment #5)
> Thanks. Done.
> 
> Version taken from CMakeLists.txt:
> https://github.com/agievich/bee2/blob/master/CMakeLists.txt
> 
> Spec URL:
> https://copr-be.cloud.fedoraproject.org/results/kashcheyeu/bee2/srpm-builds/
> 01516023/bee2.spec
> SRPM URL:
> https://copr-be.cloud.fedoraproject.org/results/kashcheyeu/bee2/srpm-builds/
> 01516023/bee2-2.0.5-4.fc31.src.rpm

As Björn was saying there is a problem with the library, it is not versioned.
Fedora requires that library are versioned: see
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries


"In cases where upstream ships unversioned .so library (so this is not needed
for plugins, drivers, etc.), the packager MUST try to convince upstream to
start versioning it.

If that fails due to unwilling or unresponsive upstream, the packager may start
versioning downstream but this must be done with caution and ideally only in
rare cases. We don’t want to create a library that could conflict with upstream
if they later start providing versioned shared libraries. Under no
circumstances should the unversioned library be shipped in Fedora.

For downstream versioning, the name should be composed like this:

libfoobar.so.0.n

The n should initially be a small integer (for instance, "1"). we use two
digits here ("0.n") because the common practice with upstreams is to use only a
single digit here. Using multiple digits helps us avoid potential future
conflicts. Do not forget to add the SONAME field (see below) to the library."

You must ask upstream to version their library. There's already commented out
code that specify versioning:
https://github.com/agievich/bee2/blob/master/src/CMakeLists.txt#L96 If upstream
do not wish to start versioning, just comment out that code in your SPEC via a
patch.


 - Source must not point to master but to a specific commit if upstream has not
released a version:

%global commit          2d8ccce67e5562023309244fe662ee21fd6caf79
%global shortcommit     %(c=%{commit}; echo ${c:0:7})
%global snapshotdate    20200602

Summary:        Cryptographic library
Name:           bee2    
Version:        2.0.5
Release:        4.%{snapshotdate}git%{shortcommit}%{?dist}

License:        GPLv3
Url:            http://apmi.bsu.by/resources/tools.html
Source0:       
https://github.com/agievich/bee2/archive/%{commit}/%{name}-%{shortcommit}.tar.gz
BuildRequires:  cmake, gcc, unzip

[…]

%prep
%autosetup -n %{name}-%{commit} -p 1


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to