https://bugzilla.redhat.com/show_bug.cgi?id=1853120

Robert-André Mauchin 🐧 <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Robert-André Mauchin 🐧 <zebo...@gmail.com> ---
 - Please name your archive better:

Source0:       
https://github.com/zlib-ng/zlib-ng/archive/%{commit}/%{name}-%{shortcommit}.tar.gz

 - Release should start at 0.1 for prerelease:


Release:        0.1.%{commitdate}git%{shortcommit}%{?dist}

 - Please make the Require arch-dependent with isa:

%package        devel
Summary:        Development files for %{name}
Requires:       %{name}%{?_isa} = %{version}-%{release}

 - Not needed anymore except for EPEL7:

%ldconfig_scriptlets

 - Please add your own changelog entry

 - Please glob the extension for man pages as the compression may change in the
future:

%{_mandir}/man3/%{name}.3.*

 - UNversioned libraries go to the -devel subpackage:

%files devel
%{_includedir}/zconf-ng.h
%{_includedir}/zlib-ng.h
%{_libdir}/libz-ng.so   
%{_datadir}/pkgconfig/%{name}.pc
%{_mandir}/man3/%{name}.3.*


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to