https://bugzilla.redhat.com/show_bug.cgi?id=1350884
Andy Mender <andymenderu...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andymenderu...@gmail.com
Assignee|nob...@fedoraproject.org |andymenderu...@gmail.com
--- Comment #21 from Andy Mender <andymenderu...@gmail.com> ---
I see this has been opened for a longer while so I'll take it :).
I can't download the sources atm, because TI is a doing scheduled maintenance,
but I had a quick look at the SPEC file:
rpmlint shows the following:
msp430-elf-toolchain.spec:51: W: unversioned-explicit-provides bundled(gnulib)
msp430-elf-toolchain.spec:295: W: macro-in-%changelog %{optflags}
msp430-elf-toolchain.spec: W: invalid-url Source0:
http://software-dl.ti.com/msp430/msp430_public_sw/mcu/msp430/MSPGCC/9_2_0_00/exports/msp430-gcc-9.2.0.50-source-full.tar.bz2
HTTP Error 404: Not Found (because the URL is unreachable?)
> URL:
> http://software-dl.ti.com/msp430/msp430_public_sw/mcu/msp430/MSPGCC/%{ti_version_number}/index_FDS.html
> Source0:
> http://software-dl.ti.com/msp430/msp430_public_sw/mcu/msp430/MSPGCC/%{ti_version_number}/exports/%{archive_name}.tar.bz2
The URL can probably be reused in the Source0 link as %{url} for brevity.
> Source1: README.fedora
> BuildRequires: bash
> BuildRequires: gcc
> [...]
If possible, leave an empty line between SourceN and BuildRequires, and sort
BuildRequires alphabetically.
> %package -n msp430-elf-gcc
> Summary: GCC for the MSP430
> Group: Development/Debuggers
> Provides: bundled(gnulib)
The Group tag is deprecated and should not be used.
> %package -n msp430-elf-gcc-c++
> Summary: GCC for the MSP430
> Group: Development/Debuggers
> %description -n msp430-elf-gcc-c++
> This is a cross compiling version of g++, which can be used to
> compile for the %{target} platform, instead of for the native %{_arch}
> platform.
An empty line before the %description in these package blocks would be nice :).
> cd binutils
> ../../binutils/configure --prefix=%{_prefix} --libdir=%{_libdir}
> %configure_args_common %configure_args_binutils
> make %{?_smp_mflags}
> cd -
Use the %make_build macro instead of make %{?_smp_mflags} where applicable.
> cd binutils
> make install DESTDIR=%{buildroot}
> cd -
Use the %make_install macro instead if possible.
I'll run licensecheck and go through the full review matrix once I have a bit
more time and access to the sources.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
