https://bugzilla.redhat.com/show_bug.cgi?id=1858360
Petr Pisar <ppi...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar <ppi...@redhat.com> ---
URL and Source0 addresses are Ok.
TODO: Remove a trailing slash from the URL value.
Source0 archive (SHA-256:
c78111ab857e48c69824903d4b6ce8293feffc6b5d670db550a767f853acc7da) is original.
Ok.
Summary verified from lib/HTTP/Headers/ActionPack.pm. OK.
TODO: The summary is not much descriptive. Have you consider not following the
upstream here? Something like "Parsing and constructing HTTP headers" would be
more helpful.
Description verified from lib/HTTP/Headers/ActionPack.pm. Ok.
License verified from Makefile.PL, LICENSE, README,
lib/HTTP/Headers/ActionPack.pm, and others. OK.
No XS code, noArch BuildArch is Ok.
FIX: Build-require "perl-interpreter" (perl-HTTP-Headers-ActionPack.spec:44).
TODO: Use %{make_build} and %{make_install} instead of "make %{?_smp_mflags}"
and "make pure_install".
TODO: Remove "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null
\;". It's not needed.
FIX: Build-require "make" (perl-HTTP-Headers-ActionPack.spec:58).
FIX: Build-require "coreutils" (perl-HTTP-Headers-ActionPack.spec:66).
TODO: Packaging both README and REAMDE.md seens redundant. Consider dropping
README.
TODO: Constrain "perl(ExtUtils::MakeMaker)" with ">= 6.30" (Makefile.PL:7).
HTTP::Message::PSGI is optional and build-required. Ok.
Web::Request is optional and not build-required. Ok.
TODO: Plack::Request and Plack::Response are used by tests only. Please
categorize them as "Testsuite only". Not as "Optional runtime".
Test::Spelling, Test::NoTabs, Test::Pod::LinkCheck, Test::Pod::No404s, and
Test::Pod are not used. Ok.
TODO: Consider unsetting AUTHOR_TESTING and RELEASE_TESTING environment
variable in %check section to make sure the modules are not used.
All tests pass. Ok.
$ rpmlint perl-HTTP-Headers-ActionPack.spec
../SRPMS/perl-HTTP-Headers-ActionPack-0.09-1.fc33.src.rpm
../RPMS/noarch/perl-HTTP-Headers-ActionPack-0.09-1.fc33.noarch.rpm
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p
../RPMS/noarch/perl-HTTP-Headers-ActionPack-0.09-1.fc33.noarch.rpm
drwxr-xr-x 2 root root 0 Jul 20 15:03
/usr/share/doc/perl-HTTP-Headers-ActionPack
-rw-r--r-- 1 root root 2120 Jun 18 2013
/usr/share/doc/perl-HTTP-Headers-ActionPack/Changes
-rw-r--r-- 1 root root 327 Jun 18 2013
/usr/share/doc/perl-HTTP-Headers-ActionPack/README
-rw-r--r-- 1 root root 1513 Jun 18 2013
/usr/share/doc/perl-HTTP-Headers-ActionPack/README.md
drwxr-xr-x 2 root root 0 Jul 20 15:03
/usr/share/licenses/perl-HTTP-Headers-ActionPack
-rw-r--r-- 1 root root 18389 Jun 18 2013
/usr/share/licenses/perl-HTTP-Headers-ActionPack/LICENSE
-rw-r--r-- 1 root root 3652 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack.3pm.gz
-rw-r--r-- 1 root root 2060 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::AcceptCharset.3pm.gz
-rw-r--r-- 1 root root 1889 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::AcceptLanguage.3pm.gz
-rw-r--r-- 1 root root 1866 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::AuthenticationInfo.3pm.gz
-rw-r--r-- 1 root root 2137 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Authorization.3pm.gz
-rw-r--r-- 1 root root 1996 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Authorization::Basic.3pm.gz
-rw-r--r-- 1 root root 2076 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Authorization::Digest.3pm.gz
-rw-r--r-- 1 root root 2421 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::ContentNegotiation.3pm.gz
-rw-r--r-- 1 root root 1638 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::Base.3pm.gz
-rw-r--r-- 1 root root 1673 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::BaseAuthHeader.3pm.gz
-rw-r--r-- 1 root root 1739 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::BaseHeaderList.3pm.gz
-rw-r--r-- 1 root root 1848 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::BaseHeaderType.3pm.gz
-rw-r--r-- 1 root root 1805 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::BaseHeaderWithParams.3pm.gz
-rw-r--r-- 1 root root 2210 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::DateHeader.3pm.gz
-rw-r--r-- 1 root root 1977 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::LinkHeader.3pm.gz
-rw-r--r-- 1 root root 1651 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::LinkList.3pm.gz
-rw-r--r-- 1 root root 2255 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::MediaType.3pm.gz
-rw-r--r-- 1 root root 2173 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::MediaTypeList.3pm.gz
-rw-r--r-- 1 root root 2188 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::PriorityList.3pm.gz
-rw-r--r-- 1 root root 1872 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Util.3pm.gz
-rw-r--r-- 1 root root 1953 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::WWWAuthenticate.3pm.gz
drwxr-xr-x 2 root root 0 Jul 20 15:03
/usr/share/perl5/vendor_perl/HTTP
drwxr-xr-x 2 root root 0 Jul 20 15:03
/usr/share/perl5/vendor_perl/HTTP/Headers
drwxr-xr-x 2 root root 0 Jul 20 15:03
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack
-rw-r--r-- 1 root root 10624 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack.pm
-rw-r--r-- 1 root root 2903 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/AcceptCharset.pm
-rw-r--r-- 1 root root 2359 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/AcceptLanguage.pm
-rw-r--r-- 1 root root 2297 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/AuthenticationInfo.pm
drwxr-xr-x 2 root root 0 Jul 20 15:03
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Authorization
-rw-r--r-- 1 root root 3613 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Authorization.pm
-rw-r--r-- 1 root root 3536 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Authorization/Basic.pm
-rw-r--r-- 1 root root 2612 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Authorization/Digest.pm
-rw-r--r-- 1 root root 7705 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/ContentNegotiation.pm
drwxr-xr-x 2 root root 0 Jul 20 15:03
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Core
-rw-r--r-- 1 root root 1549 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Core/Base.pm
-rw-r--r-- 1 root root 2115 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Core/BaseAuthHeader.pm
-rw-r--r-- 1 root root 2057 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Core/BaseHeaderList.pm
-rw-r--r-- 1 root root 2291 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Core/BaseHeaderType.pm
-rw-r--r-- 1 root root 2721 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Core/BaseHeaderWithParams.pm
-rw-r--r-- 1 root root 3468 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/DateHeader.pm
-rw-r--r-- 1 root root 4214 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/LinkHeader.pm
-rw-r--r-- 1 root root 1649 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/LinkList.pm
-rw-r--r-- 1 root root 5159 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/MediaType.pm
-rw-r--r-- 1 root root 4605 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/MediaTypeList.pm
-rw-r--r-- 1 root root 4150 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/PriorityList.pm
-rw-r--r-- 1 root root 2785 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/Util.pm
-rw-r--r-- 1 root root 2368 Jun 18 2013
/usr/share/perl5/vendor_perl/HTTP/Headers/ActionPack/WWWAuthenticate.pm
File layout and permissions are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-HTTP-Headers-ActionPack-0.09-1.fc33.noarch.rpm | sort -f |
uniq -c
1 perl(:MODULE_COMPAT_5.32.0)
1 perl(Carp)
1 perl(Encode)
1 perl(HTTP::Date)
1 perl(HTTP::Headers::ActionPack::Authorization::Basic)
1 perl(HTTP::Headers::ActionPack::Authorization::Digest)
1 perl(HTTP::Headers::ActionPack::Core::Base)
1 perl(HTTP::Headers::ActionPack::Core::BaseAuthHeader)
1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderList)
1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderType)
1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderWithParams)
1 perl(HTTP::Headers::ActionPack::LinkHeader)
1 perl(HTTP::Headers::ActionPack::MediaType)
1 perl(HTTP::Headers::ActionPack::PriorityList)
1 perl(HTTP::Headers::ActionPack::Util)
1 perl(HTTP::Headers::Util)
1 perl(List::Util)
1 perl(MIME::Base64)
1 perl(Module::Runtime)
1 perl(overload)
1 perl(parent)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(Sub::Exporter)
1 perl(Time::Piece)
1 perl(URI::Escape)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p
../RPMS/noarch/perl-HTTP-Headers-ActionPack-0.09-1.fc33.noarch.rpm | sort -f |
uniq -c
1 perl(HTTP::Headers::ActionPack) = 0.09
1 perl(HTTP::Headers::ActionPack::AcceptCharset) = 0.09
1 perl(HTTP::Headers::ActionPack::AcceptLanguage) = 0.09
1 perl(HTTP::Headers::ActionPack::AuthenticationInfo) = 0.09
1 perl(HTTP::Headers::ActionPack::Authorization) = 0.09
1 perl(HTTP::Headers::ActionPack::Authorization::Basic) = 0.09
1 perl(HTTP::Headers::ActionPack::Authorization::Digest) = 0.09
1 perl(HTTP::Headers::ActionPack::ContentNegotiation) = 0.09
1 perl(HTTP::Headers::ActionPack::Core::Base) = 0.09
1 perl(HTTP::Headers::ActionPack::Core::BaseAuthHeader) = 0.09
1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderList) = 0.09
1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderType) = 0.09
1 perl(HTTP::Headers::ActionPack::Core::BaseHeaderWithParams) = 0.09
1 perl(HTTP::Headers::ActionPack::DateHeader) = 0.09
1 perl(HTTP::Headers::ActionPack::LinkHeader) = 0.09
1 perl(HTTP::Headers::ActionPack::LinkList) = 0.09
1 perl(HTTP::Headers::ActionPack::MediaType) = 0.09
1 perl(HTTP::Headers::ActionPack::MediaTypeList) = 0.09
1 perl(HTTP::Headers::ActionPack::PriorityList) = 0.09
1 perl(HTTP::Headers::ActionPack::Util) = 0.09
1 perl(HTTP::Headers::ActionPack::WWWAuthenticate) = 0.09
1 perl-HTTP-Headers-ActionPack = 0.09-1.fc33
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-HTTP-Headers-ActionPack-0.09-1.fc33.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora 33
(https://koji.fedoraproject.org/koji/taskinfo?taskID=47494943). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the "FIX" items, and consider fixing the "TODO" items before
building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
