https://bugzilla.redhat.com/show_bug.cgi?id=1858256
--- Comment #3 from cli...@gmail.com --- I made most of changes according to the review. spec file: https://download.copr.fedorainfracloud.org/results/clime/rpm-git-tag-sort/fedora-rawhide-x86_64/01565909-rpm-git-tag-sort/rpm-git-tag-sort.spec srpm: https://download.copr.fedorainfracloud.org/results/clime/rpm-git-tag-sort/fedora-rawhide-x86_64/01565909-rpm-git-tag-sort/rpm-git-tag-sort-0.1-1.fc33.src.rpm copr build: https://copr.fedorainfracloud.org/coprs/clime/rpm-git-tag-sort/build/1565909/ I am unsure about the usage of LDFLAGS. When used, I couldn't link the project successfully on my machine due to missing symbols from libgit. I also did not provide %doc as I believe the project is quite minimal and rpm summary and command-line help is sufficient. Please take a look if you can. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
