https://bugzilla.redhat.com/show_bug.cgi?id=1857199
Kalev Lember <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #3 from Kalev Lember <[email protected]> --- This looks fine to me. I won't do a full review here as the packaging guidelines don't require a full review when packaging a new parallel installable version of the same library. Some notes: 1) > # typedarray-arg-set-values-same-buffer-other-type.js is failing on s390x > %ifarch s390x s390 > %global require_tests 0 > %endif Would be nice to disable the single failing test instead of just disabling all the tests. This way, we know as soon as something regresses in the toolchain etc. 2) > %files > %doc README.html Is there a license file to include? Would be nice to include that if possible. Beyond that, looks good to me :) Thanks for packaging it up, FrantiĊĦek! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
