https://bugzilla.redhat.com/show_bug.cgi?id=1862306
--- Comment #4 from Andy Mender <[email protected]> --- > I'm not too versed in CMake, but the impression I got from reading the > CMakeLists.txt is that it builds a dynamic library containing most of the > logic, whereas the "easyrpg-player" executable and the test runners are just > thin wrappers around the lib. I modified the CMakeLists to build a static > library instead. Both the player and the tests seem to run fine, and it gets > rid of the .so file. Yes, that was also my impression, but that is completely okay - we want a shared library. According to the packaging guidelines, packaging static libraries should be avoided if possible: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries What you can do is kindly ask upstream to version their libEasyRPG_Player shared lib. This is done by setting the VERSION and SOVERSION properties of the EasyRPG_player target (added via add_library in this CMakeLists file: https://github.com/EasyRPG/Player/blob/master/CMakeLists.txt). set_target_property(${PROJECT_NAME} PROPERTIES VERSION ${PROJECT_VERSION}) set_target_property(${PROJECT_NAME} PROPERTIES SOVERSION ${PROJECT_VERSION_MAJOR}) Short-term, you can either hack it into the SPEC file or better yet, create a patch against the CMakeLists file in question which could be a part of the fix to upstream. Since it's only 2 isolated lines, it shouldn't interfere with the flow of the CMakeLists file. If you want to force the lib to be a shared one, you can use this cmake flag: -DBUILD_SHARED_LIBS=ON -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
