Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=660095 Jussi Lehtola <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Jussi Lehtola <[email protected]> 2010-12-05 11:51:57 EST --- Final comments: As SOURCE1 is a self-created file, please add a comment to the spec file about what it does. For instance # Wrapper script for making sure hardware acceleration is available Source1: %{name}.sh ** Please don't mix %{name} and "impressive" in %files. Choose one and stick with it. Also, please be more explicit in %files. Free use of wildcards can end up in unwanted things, for instance if something goes wrong in the install you might not detect it if you use a wildcard. Explicit specs are also easier to read (you see straight away what files are installed). When you have dozens of binaries, wildcards have their place. Thus, please replace %{_mandir}/man1/* with the more explicit %{_mandir}/man1/impressive.1* (or, if you want to use %{name} in %files, use %{name} here as well). ** Please address these issues before git import. This package has been APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
