https://bugzilla.redhat.com/show_bug.cgi?id=1838027
--- Comment #25 from Miro Hrončok <mhron...@redhat.com> ---
Other than that:
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
1) Some of the packages put files into /usr/lib/systemd/system but they don't
co-own the directories nor do they require systemd. You need to do one of
the things.
2) zuul.noarch: W: no-documentation
Consider adding %doc README.rst to the main package.
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0", "*No copyright*
Apache License 2.0 GPL (v3.0)", "*No copyright* Apache License 2.0",
"Expat License", "GPL (v3 or later)". 1651 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/systemd,
/usr/lib/systemd/system
[-]: Package contains no bundled libraries without FPC exception.
It bundles ansibles, but there is marked.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
(The justification is within the patches.)
[x]: Scriptlets must be sane, if used.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: zuul-3.19.1-1.fc33.noarch.rpm
zuul-webui-3.19.1-1.fc33.noarch.rpm
zuul-scheduler-3.19.1-1.fc33.noarch.rpm
zuul-merger-3.19.1-1.fc33.noarch.rpm
zuul-web-3.19.1-1.fc33.noarch.rpm
zuul-executor-3.19.1-1.fc33.noarch.rpm
zuul-fingergw-3.19.1-1.fc33.noarch.rpm
zuul-migrate-3.19.1-1.fc33.noarch.rpm
zuul-doc-3.19.1-1.fc33.noarch.rpm
zuul-3.19.1-1.fc33.src.rpm
zuul.noarch: W: no-documentation
zuul.noarch: W: non-standard-uid /etc/zuul zuul
zuul.noarch: W: non-standard-gid /etc/zuul zuul
zuul.noarch: W: non-standard-uid /etc/zuul/logging.conf zuul
zuul.noarch: W: non-standard-gid /etc/zuul/logging.conf zuul
zuul.noarch: W: non-standard-uid /etc/zuul/main.yaml zuul
zuul.noarch: W: non-standard-gid /etc/zuul/main.yaml zuul
zuul.noarch: W: non-standard-uid /etc/zuul/zuul.conf zuul
zuul.noarch: W: non-standard-gid /etc/zuul/zuul.conf zuul
zuul.noarch: E: non-readable /etc/zuul/zuul.conf 640
zuul.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/zuul/ansible/base/library/command.py 644
/usr/bin/python3
zuul.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/zuul/ansible/base/library/zuul_console.py 644
/usr/bin/python3
zuul.noarch: W: non-standard-uid /var/lib/zuul zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/.ssh zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/.ssh zuul
zuul.noarch: W: hidden-file-or-dir /var/lib/zuul/.ssh
zuul.noarch: W: hidden-file-or-dir /var/lib/zuul/.ssh
zuul.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/keys zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/keys zuul
zuul.noarch: W: non-standard-uid /var/log/zuul zuul
zuul.noarch: W: non-standard-gid /var/log/zuul zuul
zuul.noarch: W: log-files-without-logrotate ['/var/log/zuul']
zuul.noarch: W: no-manual-page-for-binary zuul
zuul.noarch: W: no-manual-page-for-binary zuul-bwrap
zuul-webui.noarch: W: no-documentation
zuul-scheduler.noarch: W: spelling-error %description -l en_US gearman -> gear
man, gear-man, germane
zuul-scheduler.noarch: W: no-documentation
zuul-scheduler.noarch: W: no-manual-page-for-binary zuul-scheduler
zuul-merger.noarch: W: no-documentation
zuul-merger.noarch: W: no-manual-page-for-binary zuul-merger
zuul-web.noarch: W: no-documentation
zuul-web.noarch: W: no-manual-page-for-binary zuul-web
zuul-executor.noarch: E: devel-dependency libffi-devel
zuul-executor.noarch: E: explicit-lib-dependency libffi-devel
zuul-executor.noarch: W: no-documentation
zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul
zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul
zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/executor zuul
zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/executor zuul
zuul-executor.noarch: W: no-manual-page-for-binary zuul-executor
zuul-executor.noarch: W: no-manual-page-for-binary zuul-manage-ansible
zuul-fingergw.noarch: W: no-documentation
zuul-fingergw.noarch: W: no-manual-page-for-binary zuul-fingergw
zuul-migrate.noarch: W: no-documentation
zuul-migrate.noarch: W: no-manual-page-for-binary zuul-migrate
zuul-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/zuul-doc/html/objects.inv
10 packages and 0 specfiles checked; 5 errors, 44 warnings.
Rpmlint (installed packages)
----------------------------
zuul-webui.noarch: W: no-documentation
zuul-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/zuul-doc/html/objects.inv
zuul.noarch: W: no-documentation
zuul.noarch: W: non-standard-uid /etc/zuul zuul
zuul.noarch: W: non-standard-gid /etc/zuul zuul
zuul.noarch: W: non-standard-uid /etc/zuul/logging.conf zuul
zuul.noarch: W: non-standard-gid /etc/zuul/logging.conf zuul
zuul.noarch: W: non-standard-uid /etc/zuul/main.yaml zuul
zuul.noarch: W: non-standard-gid /etc/zuul/main.yaml zuul
zuul.noarch: W: non-standard-uid /etc/zuul/zuul.conf zuul
zuul.noarch: W: non-standard-gid /etc/zuul/zuul.conf zuul
zuul.noarch: E: non-readable /etc/zuul/zuul.conf 640
zuul.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/zuul/ansible/base/library/command.py 644
/usr/bin/python3
zuul.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/zuul/ansible/base/library/zuul_console.py 644
/usr/bin/python3
zuul.noarch: W: non-standard-uid /var/lib/zuul zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/.ssh zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/.ssh zuul
zuul.noarch: W: hidden-file-or-dir /var/lib/zuul/.ssh
zuul.noarch: W: hidden-file-or-dir /var/lib/zuul/.ssh
zuul.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul
zuul.noarch: W: non-standard-uid /var/lib/zuul/keys zuul
zuul.noarch: W: non-standard-gid /var/lib/zuul/keys zuul
zuul.noarch: W: non-standard-uid /var/log/zuul zuul
zuul.noarch: W: non-standard-gid /var/log/zuul zuul
zuul.noarch: W: log-files-without-logrotate ['/var/log/zuul']
zuul.noarch: W: no-manual-page-for-binary zuul
zuul.noarch: W: no-manual-page-for-binary zuul-bwrap
zuul-executor.noarch: E: devel-dependency libffi-devel
zuul-executor.noarch: E: explicit-lib-dependency libffi-devel
zuul-executor.noarch: W: no-documentation
zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul
zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul
zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/executor zuul
zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/executor zuul
zuul-executor.noarch: W: no-manual-page-for-binary zuul-executor
zuul-executor.noarch: W: no-manual-page-for-binary zuul-manage-ansible
zuul-web.noarch: W: no-documentation
zuul-web.noarch: W: no-manual-page-for-binary zuul-web
zuul-fingergw.noarch: W: no-documentation
zuul-fingergw.noarch: W: no-manual-page-for-binary zuul-fingergw
zuul-scheduler.noarch: W: spelling-error %description -l en_US gearman -> gear
man, gear-man, germane
zuul-scheduler.noarch: W: no-documentation
zuul-scheduler.noarch: W: no-manual-page-for-binary zuul-scheduler
zuul-merger.noarch: W: no-documentation
zuul-merger.noarch: W: no-manual-page-for-binary zuul-merger
zuul-migrate.noarch: W: no-documentation
zuul-migrate.noarch: W: no-manual-page-for-binary zuul-migrate
9 packages and 0 specfiles checked; 5 errors, 44 warnings.
Source checksums
----------------
https://files.pythonhosted.org/packages/source/z/zuul/zuul-3.19.1.tar.gz :
CHECKSUM(SHA256) this package :
94bbf2c16a38fc2eb851eae1aea0bed0fdb94496f1133ef159ff14f256718c2d
CHECKSUM(SHA256) upstream package :
94bbf2c16a38fc2eb851eae1aea0bed0fdb94496f1133ef159ff14f256718c2d
Requires
--------
zuul (rpmlib, GLIBC filtered):
((python3.9dist(cheroot) < 8.1 or python3.9dist(cheroot) > 8.2) with
(python3.9dist(cheroot) < 8.2 or python3.9dist(cheroot) > 8.3) with
(python3.9dist(cheroot) < 8.3 or python3.9dist(cheroot) > 8.3))
((python3.9dist(gear) < 0.15 or python3.9dist(gear) > 0.15) with
python3.9dist(gear) < 1 with python3.9dist(gear) >= 0.13)
((python3.9dist(urllib3) < 1.25.4 or python3.9dist(urllib3) > 1.25.4) with
(python3.9dist(urllib3) < 1.25.5 or python3.9dist(urllib3) > 1.25.5))
((python3.9dist(virtualenv) < 20 or python3.9dist(virtualenv) > 20) with
(python3.9dist(virtualenv) < 20.0.1 or python3.9dist(virtualenv) > 20.0.1) with
python3.9dist(virtualenv) > 20)
(python3.9dist(prettytable) < 0.8 with python3.9dist(prettytable) >= 0.6)
/bin/sh
/usr/bin/python3
config(zuul)
python(abi)
python3.9dist(alembic)
python3.9dist(apscheduler)
python3.9dist(babel)
python3.9dist(cachecontrol)
python3.9dist(cachetools)
python3.9dist(cherrypy)
python3.9dist(cryptography)
python3.9dist(extras)
python3.9dist(fb-re2)
python3.9dist(github3-py)
python3.9dist(gitpython)
python3.9dist(iso8601)
python3.9dist(jsonpath-rw)
python3.9dist(kazoo)
python3.9dist(netaddr)
python3.9dist(paho-mqtt)
python3.9dist(paramiko)
python3.9dist(pathspec)
python3.9dist(pbr)
python3.9dist(psutil)
python3.9dist(pyjwt)
python3.9dist(python-daemon)
python3.9dist(python-dateutil)
python3.9dist(pyyaml)
python3.9dist(routes)
python3.9dist(setuptools)
python3.9dist(sqlalchemy)
python3.9dist(statsd)
python3.9dist(voluptuous)
python3.9dist(ws4py)
zuul-webui (rpmlib, GLIBC filtered):
zuul-scheduler (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/python3
zuul
zuul-merger (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/python3
zuul
zuul-web (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/python3
nodejs
zuul
zuul-executor (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/python3
bubblewrap
gcc
git-core
libffi-devel
python3-devel
zuul
zuul-fingergw (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/python3
zuul
zuul-migrate (rpmlib, GLIBC filtered):
/usr/bin/python3
bubblewrap
zuul
zuul-doc (rpmlib, GLIBC filtered):
Provides
--------
zuul:
config(zuul)
python3.9dist(zuul)
python3dist(zuul)
zuul
zuul-webui:
zuul-webui
zuul-scheduler:
zuul-scheduler
zuul-merger:
zuul-merger
zuul-web:
zuul-web
zuul-executor:
zuul-executor
zuul-fingergw:
zuul-fingergw
zuul-migrate:
zuul-migrate
zuul-doc:
zuul-doc
Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17
Command line :try-fedora-review -b 1838027 -m fedora-rawhide-x86_64
--mock-options=--enablerepo=local
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: PHP, Ocaml, fonts, C/C++, SugarActivity, Perl, Ruby, Java,
Haskell, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
