https://bugzilla.redhat.com/show_bug.cgi?id=1870208



--- Comment #3 from Pavel Valena <[email protected]> ---
Thank you for your reviews!

>   - What is the reason to include vips-devel instead of just vips?

You're right, I thought I needed headers, but I don't.

>   - I think there should be something aka `Requires: vips`

Yes, you're right. I've tried using it in the test suite of image_processing
gem (which succeeds).

> * Wrong shebangs:

Hmm. I've already fixed that (I've linked probably an earlier iteration of spec
file by mistake).


Refreshed SPEC and SRPM with the changes (the release bump is just for COPR).

Spec:
https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01619049-rubygem-ruby-vips/rubygem-ruby-vips.spec
SRPM:
https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01619049-rubygem-ruby-vips/rubygem-ruby-vips-2.0.17-2.fc34.src.rpm


Builds & Test log:
https://gist.github.com/pvalena/7dc8d06603fc58c7f207cd854a1d4b8d


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to