https://bugzilla.redhat.com/show_bug.cgi?id=1874138



--- Comment #16 from Robert-André Mauchin 🐧 <zebo...@gmail.com> ---
# xsetroot

 - Install the license file with %license in files. Add the docs too.

%files
%license COPYING
%doc ChangeLog README
%{_bindir}/xsetroot
%{_mandir}/man1/xsetroot.1*

 - Please add a proper description:

xsetroot.x86_64: E: no-description-tag
xsetroot.src: E: no-description-tag

Package not yet approved. Send an updated SPEC.


[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: xsetroot-1.1.2-1.fc34.x86_64.rpm
          xsetroot-debuginfo-1.1.2-1.fc34.x86_64.rpm
          xsetroot-debugsource-1.1.2-1.fc34.x86_64.rpm
          xsetroot-1.1.2-1.fc34.src.rpm
xsetroot.x86_64: E: no-description-tag
xsetroot.src: E: no-description-tag
4 packages and 0 specfiles checked; 2 errors, 0 warnings.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to