Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661354

Julian Aloofi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
                   |                            |m

--- Comment #2 from Julian Aloofi <[email protected]> 2010-12-08 
12:23:05 EST ---
Okay, I'll take this.

Some quick drive-by comments from a first glance at the spec:
- BuildRequires needs to be on python2-devel, as it's a python2 package as far
as I can see

some cosmetical stuff:
- you don't actually need to define the python_sitearch, RPM does that
automatically now (assuming you won't build this on Fedora 12 or even lower)
- you can leave the BuildRoot tag out as well and don't need to clean the
buildroot before %install now
- you can leave out the %clean section

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to