https://bugzilla.redhat.com/show_bug.cgi?id=1857767
--- Comment #6 from Fabian Affolter <m...@fabian-affolter.ch> ---
(In reply to Miro Hrončok from comment #4)
> (In reply to Miro Hrončok from comment #1)
> > Consider adding obsoletes/provides for python3-pyephem.
>
> Added. But the obsolete uses <=, please switch to <. <= is a tad confusing
> wrt release (and works the same in this case).
Changed
> > -k "not test_jpl.py"
> >
> > Please add a comment about why is this deselected. Consider using --ignore
> > on the file directly.
>
> Not added.
Because this test is failing.
> >
> > %{python3_sitearch}/%{pypi_name}-%{version}-py%{python3_version}.egg-info
> >
> > Consider adding trailing slash to ensure this is a directory.
>
> Not added.
It's a file.
> When you response to my feedback with a new spec file, could you please
> actually say what was changed? Otherwise I need to backtrack your changes.
> Thank you.
Sure, sorry.
%changelog
* Mon Sep 14 2020 Fabian Affolter <m...@fabian-affolter.ch> - 3.7.7.1-3
- Ignore JPLTest and remove left-overs from tests
- Don't ship tests
Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-ephem.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-ephem-3.7.7.1-3.fc32.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
