https://bugzilla.redhat.com/show_bug.cgi?id=1884906



--- Comment #2 from Fabio Valentini <[email protected]> ---
(In reply to Andy Mender from comment #1)
> > BuildRequires:  python3-devel >= 3.6
> 
> The version requirement is not needed, because even Fedora 32 ships with
> Python 3.8.5 already.

I can remove the >= 3.6 requirement, but it doesn't hurt either :)

> I see that upstream provides tests:
> https://github.com/sdispater/crashtest/tree/master/tests
> However, they're not present in the PyPi package. If you'd like to include
> them, you'd need to make Source0 point to GitHub release tarballs. In
> general it's a good idea to include tests.

I am using the PyPI sources on purpose, since they include setup.py, which
isn't present in GitHub sources.
When building from GitHub it needs poetry, but I don't want to introduce a
bootstrap problem - since poetry will require crashtest with the next version.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to