https://bugzilla.redhat.com/show_bug.cgi?id=1885495



--- Comment #2 from Yogaraj Alamenda <[email protected]> ---
(In reply to Fabian Affolter from comment #1)
> Just some quick comments:
> 
> - The URL for the SPEC file needs to point to a raw text for fedora-review
> to work.
> - Remove the license from the SPEC file header.
> - qatlib is not present in the Fedora Package Collection.
> - This package needs to provide a -devel subpackage


Thanks, Comments inline.
- The URL for the SPEC file needs to point to a raw text for fedora-review
 to work.
[YA] Do we need to upload the spec file in some place in Fedora system for
review ? 
- Remove the license from the SPEC file header.
[YA] Is it mandatory that license headers cannot be there. If yes we will
remove it
- qatlib is not present in the Fedora Package Collection.
[YA] The review is still in progress for qatlib and SRPM can be downloaded from
https://github.com/intel/qatlib/releases/download/20.08.0/qatlib-20.08.0-0.1.fc32.src.rpm
- This package needsto provide a -devel subpackage
[YA] There is no other entities that need QAT Engine headers, only library is
sufficient so devel package is not included.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to