https://bugzilla.redhat.com/show_bug.cgi?id=1886621

Daniel Axelrod <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([email protected]
                   |                            |m)



--- Comment #7 from Daniel Axelrod <[email protected]> ---
Thank you for your review, approval, and sponsorship, @[email protected] !

>> - If your application is a C or C++ application you must list a
>>  BuildRequires against gcc, gcc-c++ or clang.
>>  Note: No gcc, gcc-c++ or clang found in BuildRequires
>>  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
>
> This is relatively minor, you can add this on import.

The package already BuildRequires php-devel, which Requires gcc. This should be
sufficient to ensure that gcc is available when building
php-pecl-datadog_trace. By my interpretation, this means that the package as-is
already satisfies this packaging guideline and shouldn't require modification.

However, if you believe the packaging guideline requires an explicit first
level BuildRequires on gcc, just let me know, and I'm happy to do that.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to