https://bugzilla.redhat.com/show_bug.cgi?id=1882547
Petr Pisar <ppi...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #6 from Petr Pisar <ppi...@redhat.com> ---
All tests pass. Ok.
$ rpmlint osslsigncode.spec ../SRPMS/osslsigncode-2.0-4.fc34.src.rpm
../RPMS/x86_64/osslsigncode-*2.0-4.fc34.x86_64.rpm
sh: /usr/bin/python2: No such file or directory
osslsigncode.src: W: spelling-error %description -l en_US signtool -> sign
tool, sign-tool, signatory
osslsigncode.src: W: spelling-error %description -l en_US exe -> ex, exes, exec
osslsigncode.src: W: spelling-error %description -l en_US timestamping -> time
stamping, time-stamping, times tamping
osslsigncode.src: W: spelling-error %description -l en_US cURL -> curl, URL, c
URL
osslsigncode.x86_64: W: spelling-error %description -l en_US signtool -> sign
tool, sign-tool, signatory
osslsigncode.x86_64: W: spelling-error %description -l en_US exe -> ex, exes,
exec
osslsigncode.x86_64: W: spelling-error %description -l en_US timestamping ->
time stamping, time-stamping, times tamping
osslsigncode.x86_64: W: spelling-error %description -l en_US cURL -> curl, URL,
c URL
osslsigncode.x86_64: W: no-manual-page-for-binary osslsigncode
4 packages and 1 specfiles checked; 0 errors, 9 warnings.
rpmlint is Ok.
The package builds in F34
(https://koji.fedoraproject.org/koji/taskinfo?taskID=53369918). Ok.
Resolution: Package APPROVED.
I noticed that ./testsign.sh swallows the exit code. It would be great if you
corrected it and send it to the upstream:
if [ $? -ne 0 ]; then
echo "Failure is not an option."
+ exit 1
else
echo "Yes, it works."
fi
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
