https://bugzilla.redhat.com/show_bug.cgi?id=1877006
--- Comment #4 from Jordi Sanfeliu <jo...@fibranet.cat> --- (In reply to Robert-André Mauchin 🐧 from comment #3) > Source0: > https://github.com/jcbf/smf-spf/archive/v%{version}/%{name}-%{version}.tar.gz > OK, done. > See your patch: > > diff -ru smf-spf-2.4.3.orig/Makefile smf-spf-2.4.3/Makefile > --- smf-spf-2.4.3.orig/Makefile 2020-03-26 00:45:26.000000000 +0100 > +++ smf-spf-2.4.3/Makefile 2020-06-15 11:03:57.339000000 +0200 > @@ -7,10 +7,10 @@ > CONFDIR = /etc/mail/smfs > USER = smfs > GROUP = smfs > -CFLAGS = -O2 -D_REENTRANT -fomit-frame-pointer -I/usr/local/include > +CFLAGS = -pthread $(OPTFLAGS) > > # Linux > -LDFLAGS = -lmilter -lpthread -L/usr/lib/libmilter -L/usr/local/lib -lspf2 > +LDFLAGS = -lmilter -lpthread -lspf2 > > # FreeBSD > #LDFLAGS = -lmilter -pthread -L/usr/local/lib -lspf2 > @@ -25,7 +25,6 @@ > > smf-spf: smf-spf.o > $(CC) -o smf-spf smf-spf.o $(LDFLAGS) > - strip smf-spf > > smf-spf.o: smf-spf.c > $(CC) $(CFLAGS) -c smf-spf.c > > > I don't think it is judicious to use $(OPTFLAGS) here, instead you can use > the macro %set_build_flags to define CFLAGS and LDFLAGS at the same time to > use with make afterwards: > > %set_build_flags > %make_build > > >> - Explicitly BR gcc > >I don't understand this. I've finally opted to keep the patch as is and continue including the OPTFLAGS. I've just changed the build lines as you suggested and it builds well. > For C and C++ programs, you must explicitly BuildRequires the compiler > > BuildRequires: gcc OK, done Refreshed files: Spec URL: http://ftp.fibranet.cat/smf-spf/smf-spf.spec SRPM URL: http://ftp.fibranet.cat/smf-spf/smf-spf-2.4.3-1.fc32.src.rpm Thank you very much. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
