https://bugzilla.redhat.com/show_bug.cgi?id=1885430
--- Comment #6 from [email protected] --- Spec URL: https://raw.githubusercontent.com/intel/qatlib/v20_08/rpm/qatlib.spec SRPM URL: https://raw.githubusercontent.com/intel/qatlib/v20_08/rpm/qatlib-20.08.0-1.fc32.src.rpm >The license field must reflect ALL of the licenses of the distributed >software, including anything regarded as "internal". Libraries that are >dynamically linked do not need to be referenced. Libraries that are bundled >should be removed in favor of dynamically linking against the system copies. >If this is not possible, the license field must also reference the license of >those bundled libraries. There must also be special provides directives for >the bundled libraries. Reference the guidelines [0] on how to handle bundled >libraries correctly. Based on what you are describing, if you can debundled >the OpenSSL parts, I think the correct license text should be: > > License: BSD and (BSD or GPLv2) I updated the License to: License: BSD and (BSD or GPLv2) and OpenSSL as the code contains some snippets of OpenSSL libcrypto. >This is still missing the scriptlet requirement on shadow-utils. Add this >line near the other requirements in the spec file: > > Requires(pre): shadow-utils Done. >The redundant `%dir %{_includedir}/qat` line is still there, please remove it. Done. >While fixing the version, the release was dropped. Please add it back. It >should look like this: > > * Fri Oct 16 2020 Giovanni Cabiddu <[email protected]> - 20.08.0-1 Done. On this, what level of detail would you like to see in the changelog for this phase? Should we just have a single entry for the initial version of the package? >> I need to consult the legal team to check if I can remove the license. > >For reference, there is already plenty of Intel software in Fedora under >various licenses that keep their respective spec file under the default MIT >license. I'm trying to understand internally what are the steps to change the license for this file as the project was approved as BSD. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
