https://bugzilla.redhat.com/show_bug.cgi?id=1887621
--- Comment #10 from Davide Cavalca <dcava...@fb.com> --- (In reply to Neal Gompa from comment #9) > You'd want to adjust the build script to set the soversion to match version. > Otherwise the generated dependency would be broken or otherwise wrong. > > You can see an example of how this was done with Google Test (which has > similar issues): > https://src.fedoraproject.org/rpms/gtest/blob/master/f/gtest-1.8.1- > libversion.patch Interesting, it looks like that's overriding PROPERTIES VERSION. Thoughts on doing that vs using OUTPUT_NAME ? From reading https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html and https://www.gnu.org/software/libtool/manual/html_node/Release-numbers.html#Release-numbers it sounds like for the case when the ABI changes on every release one should use libtool -release, and apparently its equivalent in cmake land is overriding OUTPUT_NAME to include the version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
