https://bugzilla.redhat.com/show_bug.cgi?id=1884255
--- Comment #10 from Miro Hrončok <[email protected]> --- Every patch should be justified in spec and/or link to upstream. In this case, I suggest to use: # Remove redundant shebang and conditional from __main__.py Patch1: https://github.com/breezy-team/patiencediff/pull/5.patch Instead of a different version of the same. ----- If you'd like to avoid the patch, you can strip the shebang in %prep with: # remove a useless shebang; fixed in upstream git sed -i '1{/^#!/d}' patiencediff/__main__.py ----- It appears that the tarball used to build the package is not the same tarball as located on the Source url: https://files.pythonhosted.org/packages/source/p/patiencediff/patiencediff-0.2.1.tar.gz : CHECKSUM(SHA256) this package : cde3ece054837358d3c64b8fd18d3e15ead5b07d8f6d20bdfacce92d8725e506 CHECKSUM(SHA256) upstream package : 9b0a00a0ec3e9fd90c3c3a280065a7c35315c8ed3f93520da0a9bcd70511a25a ----- rpmlint: python3-patiencediff.x86_64: W: spelling-error %description -l en_US difflib -> diff lib, diff-lib, difficult python3-patiencediff.x86_64: W: spelling-error %description -l en_US convience -> convince, convenience, convergence python3-patiencediff.x86_64: E: non-executable-script /usr/lib64/python3.9/site-packages/patiencediff/_patiencediff_py.py 644 /usr/bin/env python 2 packages and 0 specfiles checked; 1 errors, 2 warnings. "difflib" is probably a technical term, but "convience" seems to be an actual typo. I suggest to fix it in the %description and send a PR upstream with the same. _patiencediff_py.py still has an useless shebang. It can be removed together with the other shebang: # remove useless shebangs; fixed in upstream git sed -i '1{/^#!/d}' patiencediff/*.py -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
