https://bugzilla.redhat.com/show_bug.cgi?id=1888971

Olivier Lemasle <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Olivier Lemasle <[email protected]> ---
Please note that Fedora package for the upstream github.com/shurcooL/graphql
already exists:
https://src.fedoraproject.org/rpms/golang-github-shurcool-graphql
So you will not have to build it.

However, I am not totally comfortable with packaging a fork just for one patch;
I feel it should be fixed in github-cli instead...

But it seems to conform to Fedora packaging guidelines, so it's +1:

- MIT license ok
- Spec + changelog format ok
- Naming guidelines + packaging guidelines ok
- Builds in mock ok
- Documentation ok



Rpmlint
-------
Checking:
golang-github-cli-shurcool-graphql-devel-0-0.1.20201001git0f7232a.fc34.noarch.rpm
         
golang-github-cli-shurcool-graphql-0-0.1.20201001git0f7232a.fc34.src.rpm
golang-github-cli-shurcool-graphql-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/cli/shurcooL-graphql/.goipath
golang-github-cli-shurcool-graphql.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
golang-github-cli-shurcool-graphql-devel.noarch: W: invalid-url URL:
https://github.com/cli/shurcooL-graphql <urlopen error [Errno -3] Temporary
failure in name resolution>
golang-github-cli-shurcool-graphql-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/cli/shurcooL-graphql/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to