https://bugzilla.redhat.com/show_bug.cgi?id=1891040



--- Comment #4 from Davide Cavalca <[email protected]> ---
- as mentioned above, please add a BR to folly-devel instead of bundling it
- wcp is build is a static executable, and the built is currently setup to
disable shared libraries; I don't think there's a reason to do a static build
here
- folly doesn't build on s390x, so wdt will need an ExcludeArch for it
- wdt has tests that should be run in %check (see BUILD_TESTING in
CMakeLists.txt)
- I think you need a BR on sed, given that you're using it in %prep
- rpmlint looks ok, the only thing I'd fix there is the summary, instead of
"WDT is aiming to transfer" I'd say "tool aiming to transfer" to avoid the
repetition


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to