https://bugzilla.redhat.com/show_bug.cgi?id=1891961
Iztok Fister Jr. <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(sanjay.ankur@gmai | |l.com) --- Comment #3 from Iztok Fister Jr. <[email protected]> --- Dear reviewer (@ankursinha), Thank you very much for your comments/suggestions. Provided comments helped me to improve my SPEC file. I believe we can start another revision round. The new version of files is available on GitHub: SPEC: https://raw.githubusercontent.com/firefly-cpp/uARMSolver-rpm/main/uARMSolver.spec SRPM: https://github.com/firefly-cpp/uARMSolver-rpm/blob/main/uARMSolver-0.1-1.fc32.src.rpm?raw=true I am also attaching my answers to your comments. Issue 1: Please ensure that the srpm is generated from the spec that you've uploaded. Answer: Done Issue 2: Please move to the %files section after the %install section, and before the changelog. Answer: Done Issue 3: Please include the license file in the %files section so that they're included in the rpm. Please add this to the files section: %license LICENSE Answer: Done Issue 4: This is because the Makefile hard-codes CFLAGS (but doesn't then use these), so the Makefile needs some patching: CFLAGS = -O0 -g3 -Wall ... $(CC) -I./sources -O0 -g3 -Wall -c -fmessage-length=0 -MMD -MP -MF"$(@:%.o=%.d)" -MT"$(@)" -o "$@" "$<" ^ Should use $CFLAGS Answer: Partly done. Issue 5: The changlog should say 0.1-1 (version-release), since for each release a new changelog needs to be added. Answer: Done Issue 6: Please use %make_build, which will include the -jX bit automatically Done Issue 7: Please add the -p flag in the install command to preserve time stamps. Answer: Done Issue 8: Please wrap the description so that the length of each line is 80 characters at most. (You can run `rpmlint -i` on the spec, srpm and the generated rpms to get verbose notes.) Answer: Done Issue 9: Could the description be improved too? It speaks about a framework but the package provides a binary tool? So it's not really clear: is the tool the framework? Answer: Description was improved. Issue 10: Please include some documentation: perhaps a man page or just a text file with some instructions for users? Answer: Docs were included. Issue 11: Please use tabs or spaces consistently, and do not mix them. Answer: The use of tabs and spaces is now consistent. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
