Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #23 from Ruben Kerkhof <[email protected]> 2010-12-12 08:29:53 EST --- Hi Odel, Some comments: Replace %define modulename htmllib with %global modulename htmllib: https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define The %define python_sitelib isn't needed anymore (since F-13): https://fedoraproject.org/wiki/Packaging:Python#Macros The same goes for the BuildRoot tag and the %clean section: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag What's with all the #---------------? Please drop them. %if 0%{?fedora} >= 8 BuildRequires: python-setuptools-devel %else BuildRequires: python-setuptools %endif We're on F-14 now, so that conditional isn't needed. The %files section is a bit too general for my taste. Adding files explicitly helps you by breaking the build when newer versions of htmllib decide to drop/add files. So something like: %files %defattr(-,root,root,0755) %doc examples README %{python_sitelib}/%{modulename} %{python_sitelib}/%{modulename}-*.egg-info In the %pre section: rm -rf %{modulename}-%{version} isn't needed, that's handled by the %setup macro. And what about the tests? You should run them in a %check section, if possible. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
