https://bugzilla.redhat.com/show_bug.cgi?id=1894605

Robert-André Mauchin 🐧 <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #3 from Robert-André Mauchin 🐧 <[email protected]> ---
 - Not needed:

Group: Development/Tools

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root

rm -rf $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT/%{python3_sitelib}

%clean
rm -rf $RPM_BUILD_ROOT

%defattr(-,root,root,-)

 - Split your BR one per line:

BuildRequires: gcc
BuildRequires: numactl-devel
BuildRequires: python3-devel

 - 
make DESTDIR=$RPM_BUILD_ROOT prefix=/usr install → %make_install
prefix=%{_prefix}

 - Use macros:

/usr/bin/ → %{_bindir}

/usr/share/man/ → %{_mandir}

 - Glob the manpages extension as the compression may change in the future +
simplify the list

/usr/share/man/man8/*.8.*

 - I'm not specialist of these programs but could you justify this:

ExclusiveArch: x86_64


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to