https://bugzilla.redhat.com/show_bug.cgi?id=1896590

Neal Gompa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #3 from Neal Gompa <[email protected]> ---
Review notes:

> [!]: Package is not known to require an ExcludeArch tag.

This is not true, since folly still has an ExcludeArch: s390x. Please fill that
in appropriately.

> [!]: Package should compile and build into binary rpms on all supported
>      architectures.

See above.

Spec file review notes:

> %{python3_sitearch}/py%{name}-?.?.?-py%{python3_version}.egg-info

This version should match with the main package. According to the metadata, the
version is 1.4.1 instead of 2020.09.21.00. This is problematic because the
versioning is incoherent across different components produced by the same
source package, which can make upgrades and automatic dependencies problematic
later on. Either change the Python bindings version to match the main one, or
change the main version to match the Python bindings, but there should be only
*one* version scheme here.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to