https://bugzilla.redhat.com/show_bug.cgi?id=1884608
--- Comment #9 from Patryk Obara <dreamer.tan+fed...@gmail.com> --- I decided to explicitly mark SDL BuildRequires as >= 2.0.2. Also, added a comment to justify -O3 usage to comply with packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags say: > Overriding these flags for performance optimizations (for instance, -O3 > instead of -O2) is generally discouraged. If you can present benchmarks that > show a significant speedup for this particular code, this could be revisited > on a case-by-case basis. > Adding to and overriding or filtering parts of these flags is permitted if > there’s a good reason to do so; the rationale for doing so must be documented > in the specfile. If -O3 is not acceptable, I am willing to drop it and go back to -O2 - recent benchmarks for upcoming dosbox-staging 0.76.0 show much smaller performance improvement than what I remember from benchmarking 0.75.0. For 0.76.0 using -O3 generally gives ~1-2% performance gain in average FPS and up to 5% improvement in minimum FPS. For benchmarking I use relevant subset of https://www.philscomputerlab.com/dos-benchmark-pack.html URL with updated spec: https://raw.githubusercontent.com/dosbox-staging/dosbox-staging/a4ca6f5c45548fad2945a7e832e998777f2147af/contrib/fedora/dosbox-staging.spec diff: https://github.com/dosbox-staging/dosbox-staging/commit/a4ca6f5c45548fad2945a7e832e998777f2147af SRPM: https://github.com/dosbox-staging/dosbox-staging.github.io/releases/download/artifacts/dosbox-staging-0.75.2-2.fc33.src.rpm Koji f33: https://koji.fedoraproject.org/koji/taskinfo?taskID=55428796 Koji rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=55429208 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
