https://bugzilla.redhat.com/show_bug.cgi?id=1896742
--- Comment #7 from Andy Mender <andymenderu...@gmail.com> ---
> Source1: %{url}/raw/v%{version}/debian/udev
> Source2: %{url}/raw/v%{version}/README.md
I had a look at the source tarball again and you don't actually have to attach
additional sources with SourceX tags, since everything is already in the
tarball. Please, remove these lines.
> %prep
> %setup -q
> sed -i 's/python-radexreader /python-radexreader-rpm /g' cmd.py
> sed -i 's/#!\/usr\/bin\/python3/#/g' radexreader/__init__.py
I might be wrong, but I think the shebang and comment hashes need to be escaped
in the "sed" call like so:
> sed -i 's/\#\!\/usr\/bin\/python3/\#/g' radexreader/__init__.py
> sed -i '1i %{url}\n' README.md
Since you're the upstream developer of python-radexreader, I think it's better
to include the URL in the source tree, rather than modifying it like this in
the SPEC file. Also, that's why you got a checksum mismatch on the README.md
file.
I cleaned up the SPEC file a little:
> %prep
> %setup -q
> sed -i 's/python-radexreader /python-radexreader-rpm /g' cmd.py
> sed -i 's/\#\!\/usr\/bin\/python3/\#/g' radexreader/__init__.py
Added escapes to the second "sed" call, removed SOURCE2.
> %install
> %py3_install
> mkdir -p %{buildroot}/lib/udev/rules.d/
> mkdir -p %{buildroot}%{_datadir}/doc/python3-radexreader/
> mkdir -p %{buildroot}%{_bindir}/
> install -p -m 644 debian/udev
> %{buildroot}/lib/udev/rules.d/60-python3-radexreader.rules
> install -p -m 755 cmd.py %{buildroot}%{_bindir}/radexreader
Split the "mkdir" calls into multiple lines for clarity and later easier
creating patches. udev rules are now installed from the "debian" dir in the
source tarball, rather than being added via a SourceX tag.
Regarding sponsorship, please have a look at this doc:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
And this doc:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join
The section about the FE-NEEDSPONSOR bug report tracker is especially
important.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
